added Number.toFixed function #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@microsoft-github-policy-service agree |
|
We only allow adding properties to objects listed in diff --git a/runtime/devicescript/objects.c b/runtime/devicescript/objects.c
index b75762b7..1e80756c 100644
--- a/runtime/devicescript/objects.c
+++ b/runtime/devicescript/objects.c
@@ -261,8 +261,9 @@ static const uint8_t builtin_proto_idx[] = {
[DEVS_BUILTIN_OBJECT_BUFFER] = 10,
[DEVS_BUILTIN_OBJECT_GPIO_PROTOTYPE] = 11,
[DEVS_BUILTIN_OBJECT_GPIO] = 12,
+ [DEVS_BUILTIN_OBJECT_NUMBER_PROTOTYPE] = 13,
};
-#define MAX_PROTO 12
+#define MAX_PROTO 13
devs_maplike_t *devs_get_builtin_object(devs_ctx_t *ctx, unsigned idx) {
if (idx < sizeof(builtin_proto_idx)) {
|
|
It didn't work? |
No, it didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an empty toFixed function in
packages/core/src/number.tsand test case indevs/run-tests/02numbers.ts. when I run the test case withyarn buildandyarn test, the console will return an exceptionWASM> Exception: TypeErrorWASM> message: setting field 'toFixed' of a builtin frozen objectWASM> at prototype [as F1_pc16] (node_modules/@devicescript/core/src/number.ts:1:1)WASM> at main [as F0_pc3] (devs/run-tests/02numbers.ts:1:1)I think some settings occured this error?